Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[other] a couple more deploy cleanups #1089

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/deploy-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ jobs:
with:
node-version: ${{ env.NODE_VERSION }}

# Do this before npm configure because it writes the package.json version
- name: Write version to files
run: |
./deployment/write-versions.sh ${{ steps.next-version.outputs.result }}
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ All notable changes to the Branch Web SDK will be documented here.
The Branch Web SDK adheres to [Semantic Versioning](http://semver.org/).

## [VERSION] - unreleased
## [2.85.2] - 2024-11-11
- Updates release process
## [2.85.1] - 2024-11-04
- Updates qr image download to avoid errors
## [2.85.0] - 2024-04-10
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ all: dist/build.min.js dist/build.js test/branch-deps.js test/integration-test.h
clean:
rm -f dist/** docs/web/3_branch_web.md test/branch-deps.js dist/build.min.js.gz test/integration-test.html
release: clean all dist/build.min.js.gz
@echo "released"

test/branch-deps.js: $(SOURCES)
npx closure-make-deps \
Expand Down
2 changes: 1 addition & 1 deletion deployment/release-s3.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ make release
aws s3 cp example.html s3://branch-builds/example.html
aws s3 cp example.html s3://branch-cdn/example.html

aws s3 cp --content-type="text/javascript" --content-encoding="gzip" dist/build.js s3://branch-cdn/branch-latest.js --cache-control "max-age=300"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have this file in s3, i thought it made sense to deploy to it also

aws s3 cp --content-type="text/javascript" --content-encoding="gzip" dist/build.min.js.gz s3://branch-cdn/branch-$VERSION.min.js --cache-control "max-age=300"
aws s3 cp --content-type="text/javascript" --content-encoding="gzip" dist/build.min.js.gz s3://branch-cdn/branch-latest.min.js --cache-control "max-age=300"

echo -en "Invalidating cloudfront distribution...\n"
aws configure set preview.cloudfront true
aws cloudfront create-invalidation --distribution-id E10P37NG0GMER --paths /branch-latest.min.js


echo "Post-release sanity checks."
read -p "Can you visit https://cdn.branch.io/branch-$VERSION.min.js ?" -n 1 -r
echo
Expand Down
3 changes: 2 additions & 1 deletion examples/example.template.html
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,8 @@ <h4>QR Code</h4>
"background_color": "#FFFFFF",
"margin": 5,
"width": 1000,
"image_format": "png"
"image_format": "png",
"center_logo_url": "https://branch-assets.s3.us-west-1.amazonaws.com/branch-badge-dark.svg",
};
var qrCodeParams = {
tags: [ 'tag1', 'tag2' ],
Expand Down
3 changes: 2 additions & 1 deletion src/0_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ var DEFAULT_API_ENDPOINT = 'https://api2.branch.io';
config.app_service_endpoint = 'https://app.link';
config.link_service_endpoint = 'https://bnc.lt';
config.api_endpoint = DEFAULT_API_ENDPOINT;
config.version = '2.85.1'; // will get overwritten by gha on actual deploy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had to move this comment above because it broke the sed :/

// will get overwritten by gha on actual deploy
config.version = '2.85.2';
3 changes: 2 additions & 1 deletion test/web-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ goog.provide('config');
config.app_service_endpoint = 'https://app.link';
config.link_service_endpoint = 'https://bnc.lt';
config.api_endpoint = 'https://api.branch.io';
config.version = '2.85.1'; // will get overwritten by gha on actual deploy
// will get overwritten by gha on actual deploy
config.version = '2.85.2';
Loading