Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings; support div and rsub operations; support range() #76

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

staadecker
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.63%. Comparing base (ad485d8) to head (d6b2b4b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pyoframe/core.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   94.65%   94.63%   -0.03%     
==========================================
  Files          13       13              
  Lines        1441     1453      +12     
==========================================
+ Hits         1364     1375      +11     
- Misses         77       78       +1     
Flag Coverage Δ
smart-tests 94.63% <86.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@santiago-roig santiago-roig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is always a pain trying to manage multiple versions, but I think this is a good direction for the library to not limit our base of users.

@staadecker staadecker merged commit 75a28c9 into main Nov 12, 2024
3 of 5 checks passed
@staadecker staadecker deleted the ms/fixes branch November 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants