User story8 and User story11 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceCarollo
approved these changes
May 23, 2019
|
|
||
| click_button('Login') | ||
|
|
||
| save_and_open_page |
There was a problem hiding this comment.
Just make sure to remove this on the next PR @zachlp2016
| @@ -1,3 +1,7 @@ | |||
| <% @user.errors.full_messages.each do |msg| %> | |||
| <%= msg %> | |||
| <% end %> | |||
There was a problem hiding this comment.
High Level: Rails pipes missing/incorrect fields as errors into the User , which can then be printed on the View.
BrennanAyers
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds spec to verify that if fields are blank on forms, and error message will output stating that the fields can't be blank.
This also adds a small user story that verifies that the login outputs an error message.