-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lints: Check if stringtable entries exist and rework lints (L02) #876
base: main
Are you sure you want to change the base?
Conversation
Due to #880, we need a different solution for |
|
}; | ||
let cstring_value = cstring_data.value(); | ||
|
||
if cstring_value.to_lowercase().starts_with("str_") || cstring_value.to_lowercase().starts_with("$str_") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more self notes
x1 = "str_ace_common_cancel"; // "str_ace_common_cancel"
x2 = "$str_ace_common_cancel"; // "$str_ace_common_cancel"
x3 = "$STR_ace_common_cancel"; // "Cancel"
x4 = "$STR_ace_coMMon_cancel"; // "Cancel"
localize "str_aCe_common_canCel" // "Cancel"
localize "$str_aCe_common_canCel" // "Cancel"
config needs cased "$STR" to start but then doesn't care about case
sqf doesn't care about case or if starting with a $
this might be newish - otherwise I don't know why we have CSTRING and LSTRING macros?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the wiki $ in localize was introduced in 2.04
Ace repair hit still is a false positive - ref https://github.com/acemod/ACE3/blob/master/addons/repair/functions/fnc_getHitPointString.sqf#L29 but I've added config options so it can be ignored
|
pass buildInfo as the project is being built
currently just stores seen string-table entries but I have other ideas for this as well
unfortunately requires changing function signatures for all lints
example Explosives - Fix string acemod/ACE3#10684