Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found that
check_resid_tv
option was not working as expected.Expected behavior
I expected that when
check_resid
is set to@TV
andcheck_resid_TV
value is falsy (0 or empty), migxdbTV grid will show all existing items without checking if it is connected to current resource id.Problem
In my project with such setup, function
checkForConnectedResource
was always returningtrue
, and page with falsy check_resid_TV showed none items.I found out that in old code
$check_resid
is never falsy, because it can be set to (falsy)$check
only if$check
is truthy.Solution
After proposed changes migxdb grid in my project works as expected: