-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute Script V2 - UX #15461
Open
deanhannigan
wants to merge
23
commits into
execute-script-v2
Choose a base branch
from
execute-script-v2-frontend
base: execute-script-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Execute Script V2 - UX #15461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script-v2-frontend
…script-v2-frontend
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
…script-v2-frontend
…script-v2-frontend
…ready. Passing uninitialised stores to the derived store was causing issues
…script-v2-frontend
…script-v2-frontend
…script-v2-frontend
…ly. Rows were being misrepresented as 'Multi Select'
…script-v2-frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UX updates to accomodate the new version of the
JavaScript
automation type.JavaScript
step type (EXECUTE_SCRIPT2
)CodeEditorField
- extracted theCodeEditor
UX from deep with theBindingPanel
so that it can be used as a standalone UX. Supports JS only for the momentCodeEditor
in theBindingPanel
entirely. That is beyond the scope of this ticket.Update Row
binding UX switched back from modal to drawer mode to keep it in line with the other steps.Trigger
,User
,Step
andSettings
data. When selecting a suggestion in the dropdown, it will display any available data in the UI!JavaScript
(EXECUTE_SCRIPT
) step has been deprecated. Any automations still using the legacy step will function as before and no action is required.Fixes
Fix
- Binding icons inAttachment|Signature
drawers were all defaulted toShareAndroid
. They reflect the correct category now.Fix
- Timing issue with the Bindable drawer across the builder.CodeEditor
would get stuck with the initiating value. This caused a timing issue for all bindable inputs if they had an "update on blur" UX.Fix
- Added support for using spaces when configuring fields forApp Action
triggers. This has been an annoyance for a while.My field
encodes astrigger.fields.[My field]
and is displayed astrigger.fields.My field
.Fix
- Blurring a field name input in anApp Action
step, without altering it, would trigger an empty update and throw an errorFix
- Webhooks that have no test data would throw errors when modifying.Fix
- Minor adjustment to theApp Action
trigger field UX adding a little flexibility when configuringFix
- Addedtable
parameter to theRow action
in the test endpoint as it was missing from the test results.Fix
- Automation icons panel was displaying the incorrect icons. The list would display the icon associated with the first automation in the group. Now they reflect their corresponding automation definition typesFix
- Row types mislabelled as 'Multi select' in the bindings drawer.Addresses
Screenshots
JavaScript V2 UX. The code is directly visible and editable in the step, with suggestions and snippets . Suggestions will also render/evaluate any data in your test results or some default data
Live binding evaluation in all fields!
Launchcontrol
Automation Execute Script V2 and general Automation fixes
Feature branch env
Feature Branch Link