Feat: Combine '--mine' and '--slave' into one, make relevant account-related flags optional #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigured keystoredir
…sing the downloader to block at the checkpoint
tungng98
reviewed
Jan 8, 2025
cmd/tomo/config.go
Outdated
| Shh: whisper.DefaultConfig, | ||
| TomoX: tomox.DefaultConfig, | ||
| Node: defaultNodeConfig(), | ||
| // StakeEnable: true, |
There was a problem hiding this comment.
When code is not used anymore, please remove instead of comment
There was a problem hiding this comment.
Noted, I’ll remove unused code instead of commenting it out.
tuanha-98
force-pushed
the
optional/mine-flag
branch
from
58a537b to
194a409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces two key changes to improve flexibility and usability:
1. Make relevant account-related flags optional
--keystore,--passwordand--unlockflags can be optional and should only be required when a mining node lacks an account.2. Combine
--mineand--slaveflags into one--mineflag is defined but not used in any scenario. The--slaveflag is used when a master node wants to become a full node. To make this clearer, we can combine these into a single flag. If a full node wants to act as a master node, it can stake and enable the--mineflag along with relevant account-related flags. Conversely, if a master node wants to operate as a full node, it can disable the--mineflag and the associated account-related flags.Changes overview
Current
--mine--slavePropose
--mine--slave