-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/blockchain: add some metrics for monitoring block and state #498
Open
c98tristan
wants to merge
16
commits into
BuildOnViction:pre-release
Choose a base branch
from
c98tristan:feat/add-core-metrics
base: pre-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
core/blockchain: add some metrics for monitoring block and state #498
c98tristan
wants to merge
16
commits into
BuildOnViction:pre-release
from
c98tristan:feat/add-core-metrics
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metrics: add prometheus collector
metrics: add collector unit test, define TYPE only once
c98tristan
changed the title
Add metrics for monitoring in core/blockchain
core/blockchain: add some metrics for monitoring block and state
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites:
This pull request introduces significant changes to the Viction codebase, primarily focusing on enhancing metrics collection and reporting. The changes include the addition of new metrics, refactoring existing flags, and updating various parts of the blockchain and state management code to track and report metrics more effectively.
Metrics Enhancements:
core/blockchain.go
,core/state/state_object.go
,core/state/statedb.go
) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]Code Refactoring:
metrics
package across various files to ensure consistency and avoid redundancy. (cmd/utils/flags.go
,core/blockchain.go
,core/headerchain.go
,core/state/state_object.go
,core/state/statedb.go
) [1] [2] [3] [4]Additional Changes:
core/blockchain.go
)core/blockchain.go
,core/headerchain.go
) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]These changes collectively aim to improve the observability and performance monitoring of the Viction system, making it easier to diagnose issues and optimize the blockchain's performance.
Reference: