fmt/strtime: add %V and %:V for formatting and parsing IANA time zone identifiers #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… identifiers This matches the V specifier used by [Java's formatting/parsing infrastructure][java format]. The motivation for this is to bring the strtime APIs to parity with `jiff::fmt::temporal`. Namely, without an IANA time zone identifier, one cannot correctly roundtrip a `Zoned` value. Jiff does support `%Z` when formatting for printing time zone abbreviations like `EDT` or `EST`, but since these are ambiguous, they aren't supported while parsing. (Perhaps we should support parsing and validating them though, especially in conjunction with a IANA time zone identifier.) When using `%V`, if there is no IANA time zone identifier, then the offset without colons is used instead. To get an offset with colons, use `%:V`. [java format]: https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/format/DateTimeFormatter.html#ISO_ZONED_DATE_TIME
BurntSushi
added a commit
that referenced
this pull request
Aug 3, 2024
…rted Because they are supported now, as of #75.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the V specifier used by Java's formatting/parsing
infrastructure.
The motivation for this is to bring the strtime APIs to parity with
jiff::fmt::temporal. Namely, without an IANA time zone identifier, onecannot correctly roundtrip a
Zonedvalue.Jiff does support
%Zwhen formatting for printing time zoneabbreviations like
EDTorEST, but since these are ambiguous, theyaren't supported while parsing. (Perhaps we should support parsing and
validating them though, especially in conjunction with a IANA time zone
identifier.)
When using
%V, if there is no IANA time zone identifier, then theoffset without colons is used instead. To get an offset with colons, use
%:V.