Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable optimizations when testing #77

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Commits on Aug 3, 2024

  1. test: disable optimizations when testing

    I was getting pretty tired of the long compile times in between test
    runs. I thought they seemed particularly long for debug mode. It turns
    out that I had actually set `opt-level = 3` for running tests. This was
    because there were a select few tests that ran quite long in debug mode.
    But iteration time is important, so I trimmed down those tests and
    disabled optimizations. Tests run much more quickly now after making a
    change to the source code.
    
    We also add `cargo test --profile testrelease` to CI. This is just like
    normal tests, but disables `debug_assertions`. Jiff has a lot of extra
    stuff going on when `debug_assertions` are enabled due to its internal
    ranged integer abstraction. So it's useful to run tests without all that
    extra stuff too (reflecting what is intended to be run in production).
    
    Finally, we split win-gnu out to its own CI job and run a stripped down
    set of tests. Regretable, but it's *twice* as slow as the next slowest
    runner. That's sucks enough that we'll just live with worse test
    coverage until this becomes an obvious problem. (I'm also not even sure
    anyone is using this target anyway. It's not clear why anyone would.)
    BurntSushi committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    515a7bf View commit details
    Browse the repository at this point in the history