Changing strings to keyed to allow Translation #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really good in C#, so sometimes it looks strange. |
Byte-Nova
added
needs: testing
…-Together into development # Conflicts: # Source/Client/Core/ModStuff.cs
|
@SimobiSirOP Whenever you are able to, please move the target branch from development to translations, since that's the one where this kind of implementations go first. |
…world-Together into development # Conflicts: # Source/Client/Managers/MarketManager.cs # Source/Client/Managers/OnlineActivityManager.cs # Source/Client/Managers/PlayerSettlementManager.cs # Source/Client/Managers/WorldManager.cs # Source/Client/Network/Network.cs # Source/Client/Patches/EscMenuPatches.cs # Source/Client/Patches/Pages/WorldViewPatches.cs
|
If merged, this will also put upstream into translations branch |
|
Tested Market, Road Building, Transfers, Factions, Configs, GoodWill, works fine for me |
…world-Together into development # Conflicts: # Source/Client/Managers/CommandManager.cs
…world-Together into development # Conflicts: # Source/Client/Dialogs/RT_Dialog_Error.cs # Source/Client/Dialogs/RT_Dialog_Error_Loop.cs # Source/Client/Dialogs/RT_Dialog_ItemListing.cs # Source/Client/Dialogs/RT_Dialog_OK.cs # Source/Client/Dialogs/RT_Dialog_OK_Loop.cs # Source/Client/Dialogs/RT_Dialog_TransferMenu.cs # Source/Client/Dialogs/RT_Dialog_Wait.cs # Source/Client/Dialogs/RT_Dialog_YesNo.cs # Source/Client/Managers/CommandManager.cs # Source/Client/Managers/FactionManager.cs # Source/Client/Managers/LoginManager.cs # Source/Client/Managers/ModManager.cs # Source/Client/Managers/OnlineActivityManager.cs # Source/Client/Managers/TransferManager.cs # Source/Client/Patches/Pages/SelectStorytellerPatches.cs # Source/Client/Patches/Pages/WorldViewPatches.cs
…hanges Network changes
- Added in-game small admin menu at the ESC menu while playing. - Requires admin permission to use. - Allows to change mod configurations and custom difficulty for now.
- Xenogerms are now properly tradable. - Optimized Genepacks code.
Added compatibility with XenoGerms
Marketplace fixes
Byte-Nova
added
the
priority: low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short and concise description about my pull request:
TODOs:
Contributing:
Because it's a translation change, there isn't any need in Guide changes
Longer / More informative description about what my pull request does:
Fixes: #143