Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup model blend cursorless grammar #81

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

jaresty
Copy link
Collaborator

@jaresty jaresty commented Jun 30, 2024

  • Model blend to didn't specify a source; now it specifies the source as clipboard
  • Model blend was only implicitly dropping the 'this'

@pokey
Copy link
Collaborator

pokey commented Jun 30, 2024

This seems consistent. I think for convenience it would also be good to have:

  • "model paste" or "model paste that"
  • "model paste to "

Maybe we already have these. But they would be pretty consistent with "paste that" and "paste to "

@jaresty
Copy link
Collaborator Author

jaresty commented Jun 30, 2024

I like those. Updated.

@C-Loftus C-Loftus self-requested a review June 30, 2024 14:59
Copy link
Owner

@C-Loftus C-Loftus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should either use clip or paste and not have both in the capture. It makes it a bit cleaner to talk about commands when there is one canonical representation for any keywords inside of it.

Let's try to keep non-pipelined commands in a form somewhat similar to
model $prompt $textSource $responseMethod since it makes the mental model easier for the user when everything follows a similar grammar.

So model blend clip to $cursorless_target in my opinion is more consistent with this grammar if you are saying it is blending the clipboard as the text source with the cursorless target as the insertion method.

@jaresty
Copy link
Collaborator Author

jaresty commented Jun 30, 2024

I'm ok with either of these. Can you discuss at the meetup and make a call which way to go? I'll be afk today but I'm ok if you want to make whatever change you agree to and merge it.

@jaresty
Copy link
Collaborator Author

jaresty commented Jun 30, 2024

If you would prefer I change it, just let me know what to do and I'll put it together tonight if I can find some time. Please feel free to edit it though. The current cursorless blend command is missing a clipboard option so wanted to fix that up.

- Model blend to <target> didn't specify a source; now it specifies the source as clipboard
- Model blend <target> was only implicitly dropping the 'this'
@jaresty jaresty force-pushed the cleanup-cursor-this-model-blend-grammar branch from d69ab37 to 6563850 Compare July 1, 2024 01:49
@jaresty
Copy link
Collaborator Author

jaresty commented Jul 1, 2024

I think this aligns with the current grammar. I wasn't sure if I should be adding something for 'paste'.

@jaresty jaresty requested a review from C-Loftus July 1, 2024 01:50
@C-Loftus
Copy link
Owner

C-Loftus commented Jul 1, 2024

Looks good thanks!

@jaresty jaresty merged commit cbfb4c0 into main Jul 1, 2024
3 checks passed
@jaresty jaresty deleted the cleanup-cursor-this-model-blend-grammar branch July 1, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants