Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Article reader v3 #637

Merged
merged 114 commits into from
Oct 3, 2024
Merged

Feature: Article reader v3 #637

merged 114 commits into from
Oct 3, 2024

Conversation

danieleguido
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for journalofdigitalhistory ready!

Name Link
🔨 Latest commit 48a6a0a
🔍 Latest deploy log https://app.netlify.com/sites/journalofdigitalhistory/deploys/66ab96efac03df00088d9226
😎 Deploy Preview https://deploy-preview-637--journalofdigitalhistory.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danieleguido danieleguido mentioned this pull request Jun 4, 2024
@danieleguido danieleguido changed the title add specific css and welcome to Fred Feature: Article reader v3 Jun 20, 2024
@danieleguido
Copy link
Collaborator Author

danieleguido commented Jun 20, 2024

The update looks amazing. Here are the suggested next steps:

  • Collapsed Codemirror Cells: Expand on click and enable write mode.
  • Code Cell Output: The output result of a code cell should have the same background so that it's clear it's a direct output. Figure captions can be white on a black background.
  • Simpler Table of Content: Tailored to the new layout, possibly for me? Show the cell being executed with a simple green dot.

Other Minor Changes:

  • Remove numbers from the layer top as there's no special meaning for them, or reduce their font size.
  • Adapt the black background to a dark purple for code cells.

On the Roadmap to Washington DC:

  • Connect "run code cell" with "start" and add a pending status for the run code cell button.
  • When the kernel connection starts, the run code cell has a ready status.
  • When a cell is executing, the run code cell button has an executing status.
  • When a cell is executed, a green tick appears with the last execution datetime (to be refined at a later stage).

@eliselavy eliselavy merged commit dff19d1 into develop Oct 3, 2024
4 checks passed
@eliselavy eliselavy deleted the feature/v3 branch October 3, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants