Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4 Regressions #441

Open
7 of 8 tasks
QuintillusCFC opened this issue Apr 13, 2024 · 1 comment
Open
7 of 8 tasks

Godot 4 Regressions #441

QuintillusCFC opened this issue Apr 13, 2024 · 1 comment
Labels
godot4 PRs targeting Godot 4 branch

Comments

@QuintillusCFC
Copy link
Member

QuintillusCFC commented Apr 13, 2024

Keeping track of differences spotted between Godot 3.5 and Godot 4. This is only the outstanding ones; Paul has fixed a bunch of them, and I just fixed quite a few of the remaining.

  • When you press Build City, the highlighted city name has white font; it should have black font (likely a style issue)
  • The I-Beam in the same dialog is white (and thus hard to see), rather than black (likely a style issue?)
  • The cursor is also white rather than black and hard to see
  • The "End Turn" button should not be highlightable nor clickable while the "Build City" dialog is open, but is (this seems to apply to all the buttons as well, though only End Turn has a clear effect)
  • The spacing between right-click-menu items is slightly larger
  • The font color on hovered right-click-menu items is orange, not black (likely font_color_hover -> font_hover_color in style overrides)
  • The advisor art above the Build City Popup has some odd transparency issues going on, maybe needs shadows turned off?
  • The lower-right info box font is slightly too large (or misaligned?) (most visible when you fortify all and "ENTER or SPACEBAR for next turn" starts too far to the left)
@QuintillusCFC QuintillusCFC added the godot4 PRs targeting Godot 4 branch label Apr 13, 2024
@pcen
Copy link
Contributor

pcen commented Apr 15, 2024

thanks for helping to close a bunch of these out, the source of the regressions can be tricky to track down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
godot4 PRs targeting Godot 4 branch
Projects
None yet
Development

No branches or pull requests

2 participants