Prevent mouse interactions with map and other UI elements when popup is open #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcen
commented
Sep 29, 2024
| @@ -64,6 +88,18 @@ public void ShowPopup(Popup child, PopupCategory category) | |||
| log.Error("Invalid popup category"); | |||
| } | |||
| AudioStreamWav wav = Util.LoadWAVFromDisk(Util.Civ3MediaPath(soundFile)); | |||
|
|
|||
| // 1. prevent mouse interaction with non-UI elements (ie. the map) | |||
There was a problem hiding this comment.
Long term, need to learn how to use Godot UI properly. Couldn't find a more idiomatic solution on line for this particular problem though.
Short term, I plan to decouple UI from game logic as much as possible. This is kinda a prerequisite for decoupling game from server so that someday we could implement multiplayer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with popups described in #441. Also adjusts the spacing of the "ENTER or SPACEBAR for next turn" so it doesn't start too close to left edge.