Prevent mouse interactions with map and other UI elements when popup is open

C7/C7Game.tscn

@@ -180,7 +180,6 @@ anchors_preset = 11
 anchor_left = 1.0
 anchor_right = 1.0
 anchor_bottom = 1.0
-offset_left = -108.0
 offset_top = 80.0
 offset_right = -108.0
 offset_bottom = -170.0

C7/Credits.tscn

@@ -1,6 +1,6 @@
-[gd_scene load_steps=2 format=2]
+[gd_scene load_steps=2 format=3 uid="uid://pfefjvwiljdp"]
 
-[ext_resource path="res://Credits.cs" type="Script" id=1]
+[ext_resource type="Script" path="res://Credits.cs" id="1"]
 
 [node name="Node2D" type="Node2D"]
-script = ExtResource( 1 )
+script = ExtResource("1")

C7/GlobalSingleton.cs

@@ -2,9 +2,9 @@
 using QueryCiv3;
 
 /****
-    Need to pass values from one scene to another, particularly when loading
-    a game in main menu. This script is set to auto load in project settings.
-    See https://docs.godotengine.org/en/stable/getting_started/step_by_step/singletons_autoload.html
+	Need to pass values from one scene to another, particularly when loading
+	a game in main menu. This script is set to auto load in project settings.
+	See https://docs.godotengine.org/en/stable/getting_started/step_by_step/singletons_autoload.html
 ****/
 public partial class GlobalSingleton : Node {
 	// Will have main menu file picker set this and Game.cs pass it to C7Engine.createGame

C7/UIElements/GameStatus/LowerRightInfoBox.cs

@@ -19,7 +19,7 @@ public partial class LowerRightInfoBox : TextureRect
 	Label yearAndGold = new Label();
 
 	Timer blinkingTimer = new Timer();
-	Boolean timerStarted = false;	//This "isStopped" returns false if it's never been started.  So we need this to know if we've ever started it.
+	bool timerStarted = false;	//This "isStopped" returns false if it's never been started.  So we need this to know if we've ever started it.
 
 	// Called when the node enters the scene tree for the first time.
 	public override void _Ready()

C7/UIElements/Popups/PopupOverlay.cs

@@ -15,6 +15,8 @@ public partial class PopupOverlay : HBoxContainer
 
 	public static readonly string NodePath = "/root/C7Game/CanvasLayer/PopupOverlay";
 
+	private static readonly string ControlNodePath = "/root/C7Game/CanvasLayer/Control";
+
 	public enum PopupCategory {
 		Advisor,
 		Console,
@@ -23,9 +25,18 @@ public enum PopupCategory {
 
 	public void OnHidePopup()
 	{
+		// 1. enable mouse interaction with non-UI nodes
+		MouseFilter = MouseFilterEnum.Pass;
 		RemoveChild(currentChild);
 		currentChild = null;
 		Hide();
+
+		Control control = getControlNode();
+		// 2. enable mouse interactions with other UI elements
+		setMouseFilter(control, MouseFilterEnum.Pass);
+
+		// 3. enable clicking other UI elements
+		control.ProcessMode = ProcessModeEnum.Inherit;
 	}
 
 	public bool ShowingPopup => currentChild is not null;
@@ -37,6 +48,19 @@ public void PlaySound(AudioStreamWav wav)
 		player.Play();
 	}
 
+	private Control getControlNode() {
+		return GetNode<Control>(ControlNodePath);
+	}
+
+	private void setMouseFilter(Node n, MouseFilterEnum filter) {
+		foreach (Node child in n?.GetChildren()) {
+			setMouseFilter(child, filter);
+		}
+		if (n is Control control) {
+			control.MouseFilter = filter;
+		}
+	}
+
 	public void ShowPopup(Popup child, PopupCategory category)
 	{
 		if (child is null) {
@@ -64,6 +88,18 @@ public void ShowPopup(Popup child, PopupCategory category)
 			log.Error("Invalid popup category");
 		}
 		AudioStreamWav wav = Util.LoadWAVFromDisk(Util.Civ3MediaPath(soundFile));
+
+		// 1. prevent mouse interaction with non-UI elements (ie. the map)
+		MouseFilter = MouseFilterEnum.Stop;
+
+		Control control = getControlNode();
+
+		// 2. prevent clicking other UI elements
+		control.ProcessMode = ProcessModeEnum.Disabled;
+
+		// 3. ignore all mouse input on other UI elements (ie. button color changes on hover)
+		setMouseFilter(control, MouseFilterEnum.Ignore);
+
 		Show();
 		PlaySound(wav);
 	}
@@ -77,17 +113,11 @@ public void ShowPopup(Popup child, PopupCategory category)
 	 **/
 	public override void _UnhandledInput(InputEvent @event)
 	{
-		if (this.Visible) {
-			if (@event is InputEventKey eventKey)
-			{
-				//As I've added more shortcuts, I've realized checking all of them here could be irksome.
-				//For now, I'm thinking it would make more sense to process or allow through the ones that should go through,
-				//as most of the global ones should *not* go through here.
-				if (eventKey.Pressed)
-				{
-					GetViewport().SetInputAsHandled();
-				}
-			}
+		if (Visible && @event is InputEventKey eventKey && eventKey.Pressed) {
+			// As I've added more shortcuts, I've realized checking all of them here could be irksome.
+			// For now, I'm thinking it would make more sense to process or allow through the ones that should go through,
+			// as most of the global ones should *not* go through here.
+			GetViewport().SetInputAsHandled();
 		}
 	}
 }