ImportCiv3.cs: Add support for loading cities in scenarios #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWerner
force-pushed
the
twrner/fix-city-loading-in-scenarios
branch
from
adfc5c3 to
a1770c3
Compare
This still has some limitations, in that it will only work if there is a "Worker" unit. The `producible` field really should be loading from the list of unit prototyes, but that can be done later.
TomWerner
force-pushed
the
twrner/fix-city-loading-in-scenarios
branch
from
a1770c3 to
cab4934
Compare
|
I'm going to merge this one, pcen approved 492 which had this PR as a diffbase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still has some limitations, in that it will only work if there is a "Worker" unit. The
produciblefield really should be loading from the list of unit prototyes, but that can be done later.Some example screenshots:
The labels on the cities seems slightly amiss, and the unit health bars are somewhat obscured by the cities, but I don't think that's an issue with this PR.