Get all scenarios except 7 (Sengoku) loading properly #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWerner
force-pushed
the
twrner/improved-scenario-loading
branch
3 times, most recently
from
90c0c6c to
0190d20
Compare
pcen
approved these changes
Jan 24, 2025
TomWerner
force-pushed
the
twrner/improved-scenario-loading
branch
from
0190d20 to
4031bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes how we were loading Bic leaders, to ensure that we always have the right lookups when loading cities and units. It also changes how we pick the human player in the scenario.
To test this, I updated the save test to test both flavors of the scenarios (since they are different for some reason), and also improved the testing to confirm that the human player always has either 1+ city or 1+ settler. This helped shake out a bunch of bugs.