Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SaveTest to tolerate trailing newlines #511

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

TomWerner
Copy link
Contributor

Every time I've had to manually edit C7/Text/c7-static-map-save.json my editor keeps adding a trailing newline, which causes the test to fail.

This is super annoying and not really the goal of the test. Switching to comparing string arrays instead of byte arrays fixes this issue (while still being able to catch other bugs, like using tabs in the JSON file).

@TomWerner TomWerner merged commit 269aa1f into Development Jan 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants