Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble getting this working on an STM32L496. I had set up CANopenNode on CAN2 and it was transmitting fine but not receiving. After lots of debugging, I discovered this issue.
In
CO_driver_STM32
, theFilterBank
needs to be changed depending on the CAN peripheral. It should be0
if usingCAN1
and14
if usingCAN2
. The following preprocessor switch statement looks like it's supposed to take care of this:However, even in a dual-bank CAN device,
CAN
is defined. Here is the instance instm32l496xx.h
:This MR changes it to check instead if
CAN2
is defined, which should work on both single-CAN and dual-CAN devices.