Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pipeline function | Update on requirements | Badges & README #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

spirosmaggioros
Copy link
Member

No description provided.

Copy link
Contributor

@AlexanderGetka-cbica AlexanderGetka-cbica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DLICV shouldn't require NiChart_DLMUSE, right? Can we verify that this works standalone? the explicit pkg_resources.require line can cause issues if the environment deviates at all from what is expected, sometimes in ways that aren't supposed to be breaking.

@spirosmaggioros
Copy link
Member Author

spirosmaggioros commented Jan 14, 2025

I meant DLICV, sorry about that.

pkg_resources is already included in most python versions i believe. I don't see any issue.
I can make it more elegant in another PR though(for all the packages as well)

@spirosmaggioros
Copy link
Member Author

@AlexanderGetka-cbica Is everything ok here?

@AlexanderGetka-cbica
Copy link
Contributor

I meant DLICV, sorry about that.

pkg_resources is already included in most python versions i believe. I don't see any issue. I can make it more elegant in another PR though(for all the packages as well)

I mean that something like pkg_resources.require("DLICV") invokes behavior which checks the environment and throws errors if versions don't match. I specifically remember that at some point, spare_scores had this line, and it was checking for exact versions of its requirements, then crashing the program at run time because the NiChart_DLMUSE environment had different package versions.

Please give this a test run in the context of NiChart_DLMUSE (current main branch) and let me know if it runs successfully. Once confirmed, this is good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants