-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPLOAD-1695 Show upload status of file in info #475
Conversation
…LOAD-1695/file-upload-status
…ta-exchange-upload into UPLOAD-1695/file-upload-status
… the page is not dynamic
…ta-exchange-upload into UPLOAD-1695/file-upload-status
…LOAD-1695/file-upload-status
…LOAD-1695/file-upload-status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes, but looks excellent overall
The transition from in progress to complete is a bit jumpy IMO. Again, something else we can iterate on. I think it would be interesting to see how much normal CSS transitions and animations could improve things |
…tatus page to check elements
/> | ||
</div> | ||
<div class="input-container"> | ||
<label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need an alternative way of labeling here. The accessible name and the button name don't exactly match. I don't think it's necessary to put a Label on the button. For accessibility purposes, the label will override the button text. The accessible name for this button is now "Metadata JSON Object Note: File name will be inferred from each file Choose File: No file chosen".
…ta-exchange-upload into UPLOAD-1695/file-upload-status
Fortify Scan Results🔴 Status: ❌ Failed (Critical Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🔴 Status: ❌ Failed (Critical Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
… to not show border-top on file details if the form is hidden
Fortify Scan Results🔴 Status: ❌ Failed (Critical Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
added upload_status to the /info/ endpoint
added a pause/resume button to the progress bar section
updated the client to handle the different upload statuses