Skip to content

Commit

Permalink
lil bit of shuffling
Browse files Browse the repository at this point in the history
Co-Authored-By: jcrichlake <[email protected]>
  • Loading branch information
somesylvie and jcrichlake committed Dec 20, 2024
1 parent 3db2264 commit e830c63
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
8 changes: 1 addition & 7 deletions adr/012-configs.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,6 @@ In order to enable the usage of partner-specific settings in the different parts
in a config container in our Azure storage account. Each partner will have its own separate file within the container to minimize potential
blast radius when changing settings.


## Notes
- config files should only contain non-secret values
- secrets will use a consistent naming pattern based on the partner ID used in config (so we can dynamically assemble the key names in code)
- config keys are their file names (minus .json) and match org names in ReportStream

## Impact

### Positive
Expand All @@ -40,4 +34,4 @@ blast radius when changing settings.

## Related Issues

- #1082
- #[1082](https://github.com/CDCgov/trusted-intermediary/issues/1082)
10 changes: 7 additions & 3 deletions docs/configs.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
# FAQ

- We don't load configs in the PR environment.
- We use the partner's organization name in ReportStream as the partner ID
- Config files are the partner ID plus `.json`
- Config keys in code are the partner ID
- We don't load configs in the PR environment
- See [The partner settings struct](/src/config/config.go) for the config structure
- Configs load prior to the application running. Any changes to the config will require a restart of the Azure container to load those changes
- For local non-partner specific testing, we have a Flexion based config that can be used in non-prod environments

- Config files should only contain non-secret values. Secrets will remain in Azure Key Vault
- secrets will use a consistent naming pattern based on the same partner ID used in config
(so we can dynamically assemble the key names in code)

0 comments on commit e830c63

Please sign in to comment.