Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4xx Alerts #203

Merged
merged 4 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions operations/template/alert.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
data "azurerm_monitor_action_group" "notify_slack_email" {
count = local.non_pr_environment ? 1 : 0
resource_group_name = data.azurerm_resource_group.group.name
name = "cdcti${var.environment}-actiongroup"
}

resource "azurerm_monitor_metric_alert" "azure_4XX_alert" {
count = local.non_pr_environment ? 1 : 0
name = "cdc-rs-sftp-${var.environment}-azure-http-4XX-alert"
resource_group_name = data.azurerm_resource_group.group.name
scopes = [azurerm_linux_web_app.sftp.id]
description = "Action will be triggered when Http Status Code 4XX is greater than or equal to 3"
frequency = "PT1M" // Checks every 1 minute

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To enhance the alert's responsiveness and reduce potential downtime, consider adjusting the 'frequency' and 'window_size' parameters based on the expected traffic and error rates. This could help in faster detection and resolution of issues. [important]

window_size = "PT1H" // Every Check looks back 1 hour for 4xx errors

criteria {
metric_namespace = "Microsoft.Web/sites"
metric_name = "Http4xx"
aggregation = "Count"
operator = "GreaterThanOrEqual"
threshold = 3
}

action {
action_group_id = data.azurerm_monitor_action_group.notify_slack_email[count.index].id
}

lifecycle {
pluckyswan marked this conversation as resolved.
Show resolved Hide resolved
# Ignore changes to tags because the CDC sets these automagically
ignore_changes = [
tags["business_steward"],
tags["center"],
tags["environment"],
tags["escid"],
tags["funding_source"],
tags["pii_data"],
tags["security_compliance"],
tags["security_steward"],
tags["support_group"],
tags["system"],
tags["technical_steward"],
tags["zone"]
]
}
}
1 change: 1 addition & 0 deletions operations/template/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ locals {
rs_domain_prefix = "${local.selected_rs_environment_prefix}${length(local.selected_rs_environment_prefix) == 0 ? "" : "."}"
higher_environment_level = var.environment == "stg" || var.environment == "prd"
cdc_domain_environment = var.environment == "dev" || var.environment == "stg" || var.environment == "prd"
non_pr_environment = length(regexall("^pr\\d+", var.environment)) == 0
}

data "azurerm_resource_group" "group" {
Expand Down
10 changes: 10 additions & 0 deletions src/cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,16 @@ func setupLogging() {
func setupHealthCheck() {
slog.Info("Bootstrapping health check")

http.HandleFunc("/test400", func(response http.ResponseWriter, request *http.Request) {
slog.Info("4xx ping", slog.String("method", request.Method), slog.String("path", request.URL.String()))

response.WriteHeader(400)
_, err := io.WriteString(response, "400 Peters are Great")
if err != nil {
slog.Error("Failed to respond to health check", slog.Any(utils.ErrorKey, err))
pluckyswan marked this conversation as resolved.
Show resolved Hide resolved
}
})

http.HandleFunc("/", func(response http.ResponseWriter, request *http.Request) {
slog.Info("Health check ping", slog.String("method", request.Method), slog.String("path", request.URL.String()))

Expand Down
Loading