Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic memory alert since it is unhelpful #233

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

somesylvie
Copy link
Contributor

Description

We added dynamic memory alerts as an experiment, in addition to static memory alerts. The dynamic ones are creating false positive alerts, so we're going to delete them and just keep the static ones

Issue

CDCgov/trusted-intermediary#1606

Co-Authored-By: Bella L. Quintero <[email protected]>
Co-Authored-By: jcrichlake <[email protected]>
Co-Authored-By: James Gilmore <[email protected]>
Co-Authored-By: Samuel Aquino <[email protected]>
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@somesylvie somesylvie merged commit 8fa3a04 into main Nov 22, 2024
15 checks passed
@somesylvie somesylvie deleted the remove-dynamic-memory-alert branch November 22, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants