Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

split out live and pre-live queries #253

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

somesylvie
Copy link
Contributor

@somesylvie somesylvie commented Dec 13, 2024

Description

Split the query pack query into two separate ones for the live and pre-live slots

Issue

CDCgov/trusted-intermediary#1657

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Code Duplication
The new resources for live and pre-live logs have similar configurations and only differ in a few parameters. This could be refactored to reduce duplication and improve maintainability.

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@somesylvie somesylvie marked this pull request as ready for review December 13, 2024 16:59
@somesylvie somesylvie merged commit 679441c into main Dec 17, 2024
16 checks passed
@somesylvie somesylvie deleted the live-and-pre-live-queries branch December 17, 2024 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants