This repository was archived by the owner on Feb 7, 2025. It is now read-only.
generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 3
Config Documentation #255
Merged
Merged
Config Documentation #255
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e6f69e9
ADR update
jcrichlake 2b286b0
ADR update
jcrichlake 9aa62a3
Merge branch 'config-adr' of https://github.com/CDCgov/reportstream-s…
jcrichlake 3343e28
notes and grammar
somesylvie 4e21b64
Adding configs readme
jcrichlake 7b985d2
Adding FAQ and clarifying comments
jcrichlake 3db2264
Merge branch 'main' into config-adr
jcrichlake e830c63
lil bit of shuffling
somesylvie 6887a3c
Adding link to secrets readme
jcrichlake b33cce9
Merge branch 'main' into config-adr
jcrichlake 2b33f91
Clarifying ADR language
jcrichlake 9a1089e
Merge branch 'config-adr' of https://github.com/CDCgov/reportstream-s…
jcrichlake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# 12. Partner configuration | ||
|
||
Date: 2024-12-12 | ||
|
||
## Decision | ||
|
||
We will store partner SFTP config settings in an Azure container | ||
|
||
## Status | ||
|
||
Accepted. | ||
|
||
## Context | ||
|
||
In order to enable the usage of partner-specific settings in the different parts of the app, we are going to store the settings | ||
in a config container in our Azure storage account. Each partner will have its own separate file within the container to minimize potential | ||
blast radius when changing settings. | ||
|
||
## Impact | ||
|
||
### Positive | ||
|
||
- We can continue to meet our partners where they are by having partner specific settings in the app in order to provide any needed customizations. | ||
- We can create separate testing config for the Flexion organizations | ||
|
||
### Negative | ||
|
||
- Some added complexity for the implementation of configs. | ||
- Initial implementation of the config will require either restarting or redeploying the app | ||
|
||
### Risks | ||
|
||
- None | ||
|
||
## Related Issues | ||
|
||
- #[1082](https://github.com/CDCgov/trusted-intermediary/issues/1082) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# FAQ | ||
- We use the partner's organization name in ReportStream as the partner ID | ||
- Config files are the partner ID plus `.json` | ||
- Config keys in code are the partner ID | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could an example of what that would look like be added? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added |
||
- We don't load configs in the PR environment | ||
- See [The partner settings struct](/src/config/config.go) for the config structure | ||
- Configs load prior to the application running. Any changes to the config will require a restart of the Azure container to load those changes | ||
- For local non-partner specific testing, we have a Flexion based config that can be used in non-prod environments | ||
- Config files should only contain non-secret values. Secrets will remain in Azure Key Vault | ||
- secrets will use a consistent naming pattern based on the same partner ID used in config | ||
(so we can dynamically assemble the key names in code) [see here](../SECRETS.md) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving the FAQ section. Great idea!