Extract alert non pr conditional check as a local variable

CDCgov · Sep 13, 2024 · 1535d54 · 1535d54
1 parent c44ebe7
commit 1535d54
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/operations/template/alert.tf b/operations/template/alert.tf
@@ -1,5 +1,5 @@
 resource "azurerm_monitor_action_group" "notify_slack_email" {
-  count               = contains(["internal", "dev", "stg", "prd"], var.environment) ? 1 : 0
+  count               = local.non_pr_environment ? 1 : 0
   name                = "cdcti${var.environment}-actiongroup"
   resource_group_name = data.azurerm_resource_group.group.name
   short_name          = "cdcti-alerts"
@@ -29,7 +29,7 @@ resource "azurerm_monitor_action_group" "notify_slack_email" {
 }
 
 resource "azurerm_monitor_scheduled_query_rules_alert" "database_token_expired_alert" {
-  count               = contains(["internal", "dev", "stg", "prd"], var.environment) ? 1 : 0
+  count               = local.non_pr_environment ? 1 : 0
   name                = "cdcti-${var.environment}-api-log-token-alert"
   location            = data.azurerm_resource_group.group.location
   resource_group_name = data.azurerm_resource_group.group.name

diff --git a/operations/template/main.tf b/operations/template/main.tf
@@ -8,6 +8,7 @@ locals {
   rs_domain_prefix               = "${local.selected_rs_environment_prefix}${length(local.selected_rs_environment_prefix) == 0 ? "" : "."}"
   higher_environment_level       = var.environment == "stg" || var.environment == "prd"
   cdc_domain_environment         = var.environment == "dev" || var.environment == "stg" || var.environment == "prd"
+  non_pr_environment             = contains(["internal", "dev", "stg", "prd"], var.environment)
 }
 
 data "azurerm_resource_group" "group" {