Refactor readMetadataForMessageLinking so it doesn't return itself #1043
Conversation
…elf in the results
|
| if (messageIdsToLink == null || messageIdsToLink.isEmpty()) { | ||
| return; | ||
| } | ||
|
|
||
| // Add receivedSubmissionId to complete the list of messageIds to link | ||
| messageIdsToLink.add(receivedSubmissionId); | ||
|
|
There was a problem hiding this comment.
Does this work correctly now?
Did partnerMetadataOrchestrator.findMessagesIdsToLink(receivedSubmissionId) return receivedSubmissionId in the returned set, but now it doesn't? Is it possible that the if statement now always returns an empty set if this is the first one?
There was a problem hiding this comment.
Correct, findMessagesIdsToLink was returning receivedSubmissionId in the set. The problem with the previous logic and query is that it will return a record even if there's no pair to match, as it will always return itself. In this case, if there's a pair to match, it will return that so if won't be empty. If there's no pair to match, we want to return an empty set
Refactor readMetadataForMessageLinking so it doesn't return itself
This is a fix in the linking logic so it only matches when there's at least one pair
Issue
#621
Checklist