Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformation rule engine implementation #1046
Transformation rule engine implementation #1046
Changes from 161 commits
f5e94fe
28505a5
2c3f69d
bdd568a
f65cede
0cf5640
a08c687
8631334
6214e84
4756364
1de28ef
5c8073b
45a3bca
d5490e8
8e7398c
dbd8043
d399054
24ae3d3
90698e4
0eb2682
a865999
76b7d82
27ea75d
0f1b275
5acab7a
28b0d7a
1f57bb1
5d4dd9e
34a2bf9
e137c1d
0fc78c5
95d4b2d
a27a876
c0f0093
2a5f7ab
3bc60fe
79705c7
4a5068d
be631d7
643b314
9fd6506
a3e9ddc
2bd21c8
6ba1943
da17647
2ee0505
70851c2
8597f88
d78d0ba
a03dd0b
4e44a3b
e9290aa
7021d85
53445b3
db0cddf
f8d91b1
b3aeec9
4392b27
369d810
0ab622e
63518ba
9e49e24
79bd441
a46ac92
15c59c2
a9867af
8d88fd1
ab25de9
a0df1ed
614e102
14ec0c2
fd31ad5
ae1f2d8
b105222
511ec68
728fcb0
3b6aae1
775d8a6
c999565
fc2b07a
52c7dcf
edee43b
a0ee472
b43b99a
d32ae21
85efd28
3151384
939495b
f32da54
7a65754
ecbd9e2
fd76553
9831637
60c046a
4379229
e201d83
4130d72
ea8ab68
d2521c1
2bf76d7
e863469
f0c2b77
4ddce46
f536a69
b1ea6fc
b79279b
1c9eb48
42755db
20102de
9d8b27c
479f0cc
cddb40f
2815f4a
8c8f750
e64d775
c9614e7
043d863
89a01d0
8d52ed3
7947e86
e461d56
3bce6fc
6ec64aa
c3bb3ea
78b3360
b274082
9b22430
f722ad6
386849b
2a06236
b75a8e3
d1664b5
46bd8ef
1ed0fe3
7d68b8d
9301667
cd22fb9
1c49e22
0e4bb53
9715088
88eb52a
3c092dc
e271ce2
1281790
ef2ab1b
d0c5549
7ce3dd3
5cee63e
83b4ddb
4727eef
9729b86
02ef099
f511a5d
639ad9d
3de164a
17d7445
db3c44b
ffd54ea
f45701a
4b1a825
46306b1
7ebbb40
d567bf2
32e7e39
49709ef
0bfdb89
461aa8d
74d2c03
81364d8
d1ec9ab
9b8243a
ec714d8
8333f55
14d3e3d
95d2f96
b70f46d
7bd0a82
f818524
64ac1cc
abf4efa
14d967e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way of decoupling from the FHIR library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good question.
I'm inclined to remove all of the demographic stuff. John pushed back on that in the past, so I started a new conversation with him. Even if we decide to keep the logic, perhaps this is not a usecase for the transformation engine since we change Java types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And John says he's OK with removing it. That could be a PR in-of-itself, and then that would simplify this because the file would be removed.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed a bunch of these
metadata.put(...)
calls. We should keep these, yes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were moved to the custom functions. You can find this etor processing one in
etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/ruleengine/transformation/custom/addEtorProcessingTag.java
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above