Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified FHIR Path Mapping enum to include HL7v2 values #1087

Merged
merged 9 commits into from
May 10, 2024
Merged

Modified FHIR Path Mapping enum to include HL7v2 values #1087

merged 9 commits into from
May 10, 2024

Conversation

tjohnson7021
Copy link
Contributor

@tjohnson7021 tjohnson7021 commented May 10, 2024 •
edited
Loading

Refactor FhirPath.java to MappingPath.java

  • Updated references to fhir paths in other places
  • created placeholders for HL7v2 values

Issue #1024

Checklist

  • I have added JavaDocs where required
  • I have updated the documentation accordingly

Note: You may remove items that are not applicable

@tjohnson7021
Modified FHIR Path Mapping enum to include HL7v2 values
a98e69f 
- Updated references to fhir paths in other places
- created placeholders for HL7v2 values
@tjohnson7021 tjohnson7021 self-assigned this May 10, 2024
@tjohnson7021 tjohnson7021 marked this pull request as ready for review May 10, 2024 16:17
@tjohnson7021 tjohnson7021 requested a review from basiliskus May 10, 2024 16:22
basiliskus
basiliskus approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@basiliskus basiliskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tjohnson7021 tjohnson7021 merged commit 9838a71 into main May 10, 2024
16 checks passed
@tjohnson7021 tjohnson7021 deleted the story1024/task-results-transformation-mapping-path-refactor branch May 10, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basiliskus basiliskus basiliskus approved these changes

Assignees

@tjohnson7021 tjohnson7021

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjohnson7021 @basiliskus