Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition to handle case when running RS locally #1139

Merged
merged 10 commits into from
Jun 11, 2024

Conversation

basiliskus
Copy link
Contributor

@basiliskus basiliskus commented Jun 10, 2024

Add condition to handle case when running RS locally

Changed condition in EtorDomainRegistration to use MockRSEndpointClient only when REPORT_STREAM_URL_PREFIX is empty or null. Also making sure that the e2e tests script empties the variable since they need the endpoint mock

Issue

#649

Checklist

  • I have added tests to cover my changes
  • I have added logging where useful (with appropriate log level)
  • I have added JavaDocs where required
  • I have updated the documentation accordingly

@basiliskus basiliskus marked this pull request as ready for review June 10, 2024 22:39
Copy link

@saquino0827
Copy link
Contributor

Nice work!

@basiliskus basiliskus merged commit 3d6b742 into main Jun 11, 2024
16 checks passed
@basiliskus basiliskus deleted the story/649/handle-local-rs-endpoint-client branch June 11, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants