-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformation to update OBR-2 with ORC-4 #1190
Conversation
shared/src/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiHelper.java
Fixed
Show fixed
Hide fixed
shared/src/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiHelper.java
Fixed
Show fixed
Hide fixed
shared/src/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiHelper.java
Fixed
Show fixed
Hide fixed
shared/src/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiHelper.java
Fixed
Show fixed
Hide fixed
Add missing transformation on test case
Add implementation of OBR2 methods
…intermediary into add-obr-2-transformation
"ORC.2", | ||
""" | ||
Bundle.entry.resource.ofType(ServiceRequest).identifier.where(type.coding.code = 'PLAC').value | ||
"""), | ||
PLACER_ORDER_NUMBER_OBR_2( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this path being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got no usages coming up too; Is this a question of whether we need this now or will need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is right now, but we're also using this FHIR paths as reference. Even if not used, it's useful for us to document all the HL7 FHIR paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll approve the PR, but I would recommend that we add paths as and when they are needed. This way, we can ensure that every documented path is relevant and necessary at the time of its inclusion.
shared/src/test/groovy/gov/hhs/cdc/trustedintermediary/external/hapi/HapiHelperTest.groovy
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The swap works as expected, good job.
Transformation to update OBR-2 with ORC-4
There was a missing transformation for UCSD that we're adding here:
Update OBR-2 with content from ORC-4 in the ORU result message. Replace OBR-2.1 with original content of ORC-4.1. Replace OBR-2.2 with original content of ORC-4.2
. We are expanding theSwapPlacerOrderAndGroupNumbers
transformation to include this changesIssue
#1194
Checklist