-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformation: Modified OBR-4.3 codingSystem #1288
Conversation
Remove unused alternateId value
Do we want the alternate identifier to be emptied out if it is not specified in the transform definition? I ran a message through with this OBR:
After the transform, the final result looks like this:
Note that OBR-4.4 is now empty. CA is only sending OBR-4.1 and OBR-4.2, so it shouldn't matter for the current requirement, but it could make a difference if we receive messages that use the alternate in the future. |
Discussed with @dbgolson and @luis-pabon-tf on 9/6/2024 and updated the task. We agreed that the transform should retain the original values for subfields OBR-4.4 through 4.6. |
As it is now, all tests pass with full coverage on the new code. Approval pending verifying the original values... |
The commit I just made adds a new unit test for the empty OBR-4.4 case and updates the transform. We still need to run a new end to end test. I will do that in the morning. |
Confirmed end to end testing passed. With this configuration (note no alternateID in the args): "rules": [
{
"name": "UpdateUniversalServiceIdentifier",
"args": {
"checkValue": "54089-8",
"codingSystem": "CDPHGSPEAP"
}
}
] And an initial OBR as before:
Produces this result after the transform, retaining OBR-4.4 as-is:
|
Quality Gate passedIssues Measures |
CA Transform: OBR-4.3 Modification
UpdateUniversalServiceIdentifier
transform. Added constants for the hardcoded string values and updated the privateupdateAlternateCodingId
method to use a string parameter rather than a Map since we only use one value.Issue #1243
Checklist