ADR for deployment slots #1289
Merged
ADR for deployment slots #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: jherrflexion <[email protected]> Co-Authored-By: Samuel Aquino <[email protected]>
somesylvie
requested review from
halprin,
saquino0827,
pluckyswan,
jherrflexion and
jcrichlake
sfradkin
requested changes
Sep 4, 2024
| @@ -0,0 +1,40 @@ | |||
| # 23. Deployment Slots for Zero Downtime Deploys | |||
There was a problem hiding this comment.
I'd like to see a reason why we are using deployment slots even though there are some significant negative impacts and risks.
There was a problem hiding this comment.
Basically the other options were even worse - Kubernetes, roll our own, or switch to AWS (or abandon zero-downtime deploys). We can add a mention of the alternatives
Co-Authored-By: jcrichlake <[email protected]>
|
tjohnson7021
pushed a commit
that referenced
this pull request
Oct 17, 2024
Co-authored-by: jherrflexion <[email protected]> Co-authored-by: Samuel Aquino <[email protected]> Co-authored-by: jcrichlake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for the ADR for deployment slots
Issue
#1220