Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-assign our GitHub Project on Story Creation #1432

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

halprin
Copy link
Member

@halprin halprin commented Oct 16, 2024

Auto-assign our GitHub Project on Story Creation

Trying out the change to auto-assign a new story to our new GitHub project.

Issue

None.

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Maintainability
Avoid hardcoding project numbers in the issue template

Ensure that the project number (45 in 'CDCgov/45') is dynamically retrieved or
verified to exist, to avoid hardcoding or referencing non-existent projects.

.github/ISSUE_TEMPLATE/story.md [7-8]

 projects:
-  - CDCgov/45
+  - CDCgov/{{ project_number }}
Suggestion importance[1-10]: 7

Why: The suggestion to avoid hardcoding project numbers is relevant and improves maintainability. However, the implementation of dynamic retrieval isn't provided, which limits the practical application of the suggestion.

7

Copy link

@halprin halprin merged commit 15f7818 into main Oct 16, 2024
17 checks passed
@halprin halprin deleted the issue-template-story-to_project branch October 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants