Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example snapshots #1461

Merged
merged 34 commits into from
Oct 21, 2024
Merged

Update example snapshots #1461

merged 34 commits into from
Oct 21, 2024

Conversation

basiliskus
Copy link
Contributor

@basiliskus basiliskus commented Oct 18, 2024

Update example snapshots

  • Renamed Natus and Oracle examples to remove _0_initial_message suffix
  • Update snapshots for files with _1_hl7_translation, _2_fhir_transformation and _3_hl7_translation_final suffixes in the /examples folder

Note: examples/Test/Results/005_AL_ORU_R01_NBS_Simplified_0_initial_message.hl7 failed to deliver to RS with the following warning: Item was not routed to ignore.ETOR_TI because it did not pass the PROCESSING_MODE_FILTER. Item failed on: Bundle.entry.resource.ofType(MessageHeader).meta.tag.where(system = 'http://terminology.hl7.org/CodeSystem/v2-0103').code.exists() and Bundle.entry.resource.ofType(MessageHeader).meta.tag.where(system = 'http://terminology.hl7.org/CodeSystem/v2-0103').code = 'P'

Issue

#1436

@basiliskus basiliskus changed the base branch from main to example-snapshots-update-script October 18, 2024 21:56
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

1436 - Not compliant

Fully compliant requirements:

  • None

Not compliant requirements:

  • Create a script that submits all files in /examples with the 0_initial_message suffix to local RS.
  • Ensure files are routed correctly to deliver the final HL7 into a local folder.
  • Copy those files back with the 3_hl7_translation_final suffix.
  • Grab the FHIR copies from the local Azure storage.
  • Replace the 1_hl7_translation and 2_fhir_transformation copies in /examples.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@basiliskus basiliskus marked this pull request as ready for review October 19, 2024 16:28
@basiliskus basiliskus self-assigned this Oct 21, 2024
Copy link
Member

@halprin halprin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot of lines changed.

Base automatically changed from example-snapshots-update-script to main October 21, 2024 22:49
Copy link

@basiliskus basiliskus merged commit 30e1684 into main Oct 21, 2024
17 checks passed
@basiliskus basiliskus deleted the story/1436/update-example-snapshots branch October 21, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants