alert when instance count is low

[somesylvie]

Description

Alert when Azure instance count is low, fix logic for identifying non-PR environments

Issue

#1398

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Configuration Logic The threshold logic for the alert based on environment levels needs clarification. The current setup might not be optimal for different scaling scenarios. Commented Code There's a commented line regarding the frequency and window size of the alert. This should be resolved or removed before merging.

[github-actions]

Consider using a variable for the threshold values to make them configurable outside of the code, enhancing flexibility and maintainability. [important]

[github-actions]

Remove or address the commented line about frequency and window size to avoid confusion and ensure clarity in the alert's behavior. [important]

[github-actions]

Ensure that the 'ignore_changes' lifecycle configuration is necessary for all these tags, as it might lead to overlooking important changes. [medium]

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Enhancement	Make threshold values configurable by using a variable Consider using a variable for the threshold values to make them configurable outside the code, enhancing flexibility and maintainability. operations/template/alert.tf [140] -threshold = local.higher_environment_level ? 2.5 : 0.5 +threshold = var.instance_count_threshold Suggestion importance[1-10]: 7 Why: Using a variable for threshold values enhances flexibility and maintainability, allowing for easier adjustments without modifying the code directly.	7
	Use variables for frequency and window size to increase configuration flexibility Replace the hardcoded frequency and window size with variables to allow easy adjustments without modifying the code directly. operations/template/alert.tf [129-130] -frequency = "PT1M" // Checks every 1 minute -window_size = "PT15M" // Every Check, looks back 15 minutes in history +frequency = var.alert_frequency +window_size = var.alert_window_size Suggestion importance[1-10]: 7 Why: Replacing hardcoded values with variables for frequency and window size allows for easier configuration adjustments and improves the code's adaptability.	7
Possible issue	Review the necessity of ignoring changes to all specified tags Ensure that the ignore_changes lifecycle configuration is necessary for all these tags, as it might lead to overlooking important changes. operations/template/alert.tf [149-161] +ignore_changes = [ + tags["business_steward"], + ... + tags["zone"] +] - Suggestion importance[1-10]: 5 Why: This suggestion is valid as it prompts a review of the lifecycle configuration, which could prevent overlooking important changes. However, it is less critical than functional code changes.	5
Maintainability	Address or remove the 'TBD' comment to finalize the alert configuration Clarify or remove the 'TBD' comment regarding the frequency and window size of the alert to ensure the code is production-ready. operations/template/alert.tf [131] -//TBD: How frequent do we want this alert and how far do we want it to look back. +// Frequency and window size are set based on operational requirements. Suggestion importance[1-10]: 4 Why: Addressing or clarifying the 'TBD' comment is important for ensuring the code is production-ready, though it's a minor maintainability improvement compared to functional code changes.	4

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[halprin]

Re-approved. Looks right.