Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Setup Azure Alert for Azure is down" #1474

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

halprin
Copy link
Member

@halprin halprin commented Oct 22, 2024

Reverts #1464

The changes from that PR is failing in staging. It may be failing due to the change from my PR comment. :`( We don't know this for sure, though.

Normally, for this kind of issue, I'd favor "failing forward", but tomorrow we have the CA SME call. I rather not have a failing staging deploy for that meeting. So revert it is.

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

1464 - Not compliant

Fully compliant requirements:

  • None

Not compliant requirements:

  • Setup Azure Alert for when Azure is down using Terraform.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Contributor

@GilmoreA6 GilmoreA6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reversion due to failing deploy

Copy link

@halprin halprin merged commit 2b1a657 into main Oct 22, 2024
17 checks passed
@halprin halprin deleted the revert-1464-azure-outage-alert-pain-and-suffering branch October 22, 2024 23:06
@jherrflexion jherrflexion mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants