Specify Maintenance Window for the Database

[halprin]

Description

Our database has maintenance windows. Azure recommends setting a specific one, and specifying one reduces the randomness of when the maintenance window will occur. I set the maintenance to our SLA's maintenance window. Not that our SLA is actually set, but our draft is better than nothing.

Issue

None.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Configuration Validation Ensure that the specified maintenance window configuration aligns with the actual SLA and operational requirements.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Best practice	Add a validation check for the day_of_week field in the maintenance_window configuration Ensure that the maintenance_window configuration includes a validation check for the day_of_week value to prevent invalid configurations. Terraform supports values from 0 (Sunday) to 6 (Saturday), and an incorrect value could lead to deployment failures. operations/template/db.tf [25-29] maintenance_window { # Sunday at 12:00 UTC which is 7:00 AM EST or 8:00 AM EDT (around the time of our SLA's maintenance window) - day_of_week = 0 + day_of_week = 0 # Ensure this is between 0 and 6 start_hour = 12 start_minute = 0 } Suggestion importance[1-10]: 5 Why: The suggestion to add a validation check for the day_of_week field is relevant and can prevent potential deployment failures due to incorrect configurations. However, the suggestion does not provide a specific implementation of the validation logic, only a comment hint, which limits its impact.	5

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud