-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added rs e2e test files and assertions for truncation logic #1487
added rs e2e test files and assertions for truncation logic #1487
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks kick-ass to me. @basiliskus, mind taking a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! It's a different approach in terms of setting the conditions to test but it completely makes sense to me for this kind of use case
@basiliskus ya, I considered adding a new rule type that would check a regex and see if it matched and then we could apply it broadly but decided that could be a future enhancement and it made more sense to have specific test cases for right now |
Add a PR title
Added two new files and relevant assertions to test leading zero truncation logic in RS e2e tests.
Issue
#1454
Checklist
Note: You may remove items that are not applicable