Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting a temp var to trigger pr env build #1493

Closed
wants to merge 1 commit into from
Closed

Conversation

somesylvie
Copy link
Contributor

Add a PR title

Describe what changed in this PR at a high level.

Issue

Add a link to the issue here. Consider using
closing keywords
if the this PR isn't for a story (stories will be closed through different means).

Checklist

  • I have added tests to cover my changes
  • I have added logging where useful (with appropriate log level)
  • I have added JavaDocs where required
  • I have updated the documentation accordingly

Note: You may remove items that are not applicable

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@@ -8,6 +8,7 @@ locals {
rs_domain_prefix = "${local.selected_rs_environment_prefix}${length(local.selected_rs_environment_prefix) == 0 ? "" : "."}"
higher_environment_level = var.environment == "stg" || var.environment == "prd"
cdc_domain_environment = var.environment == "dev" || var.environment == "stg" || var.environment == "prd"
cheezburger = "cheezburger" // setting something in TF to trigger a PR build

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more descriptive variable name than cheezburger. A name that reflects its purpose or function within the Terraform configuration would improve code readability and maintainability. [important]

Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Maintainability
Ensure temporary variables are cleaned up after their intended use

Ensure that the temporary variable cheezburger is actually utilized or removed after
the PR build is triggered to avoid cluttering the Terraform configuration with
unused variables.

operations/template/main.tf [11]

-cheezburger = "cheezburger" // setting something in TF to trigger a PR build
+# cheezburger = "cheezburger" // Temporarily used to trigger a PR build, consider removing after use
Suggestion importance[1-10]: 7

Why: The suggestion to ensure the cleanup of the temporary variable 'cheezburger' after its intended use is relevant for maintaining clean and efficient code. It addresses potential clutter in the Terraform configuration, which is important for maintainability.

7

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant