Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

Adding api-response time alert #1557

Merged
merged 5 commits into from
Nov 6, 2024
+42 −0
Merged

Adding api-response time alert #1557

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6969d7
Adding api-response time alert
jcrichlake Nov 6, 2024
e59c415
Adding count ternary
jcrichlake Nov 6, 2024
7bb4404
Fixing metric_namespace
jcrichlake Nov 6, 2024
7cc6f0b
Adjusting namespace again
jcrichlake Nov 6, 2024
7abf415
Fixing scope
jcrichlake Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing metric_namespace
@jcrichlake
jcrichlake committed Nov 6, 2024
commit 7bb4404baacf497e6c98fc3b5ea9b746a21989bc
2 changes: 1 addition & 1 deletion operations/template/alert.tf
View file
Original file line number Diff line number Diff line change
@@ -528,7 +528,7 @@ resource "azurerm_monitor_metric_alert" "api-response-time-alert" {

criteria {
metric_name = "HttpResponseTime"
metric_namespace = "microsoft.web/sites"
metric_namespace = "Microsoft.Web/serverFarms"
aggregation = "Average"
operator = "GreaterThan"
threshold = 5 # Value is in seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda curious on why 5 seconds? If it's a good reason, adding a comment could be useful for future selves

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a number I just picked. It's slightly on the high side but we had some iffy latency spikes in the last week well above that number. We can potentially tweak this value later.