Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTE Integration Test #1649

Merged
merged 10 commits into from
Dec 11, 2024
Merged

NTE Integration Test #1649

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c81d60f
add an assert and example
pluckyswan Dec 6, 2024
f8d9e12
correct msh-10 value and add more rules
pluckyswan Dec 6, 2024
2c40413
update sample file and assertion rules
pluckyswan Dec 9, 2024
631c0b5
break test
pluckyswan Dec 9, 2024
c869315
add n in msh-11 for routing flag and break test
pluckyswan Dec 9, 2024
36c8585
remove breaking change
pluckyswan Dec 9, 2024
022922b
Merge branch 'main' into nte-integration-test
pluckyswan Dec 9, 2024
7427574
switch out rule
pluckyswan Dec 11, 2024
3cf0eec
Merge branch 'main' into nte-integration-test
pluckyswan Dec 11, 2024
9faaeef
Merge branch 'main' into nte-integration-test
pluckyswan Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions examples/Test/Automated/011_ORM_R01_nte_segment_mapping.hl7
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
MSH|^~\&|BaptistOracle^2.16.840.1.114222.4.1.000000^ISO|BaptistEast^2.16.840.1.114222.4.1.000001^ISO|ALlabNatus^2.16.840.1.114222.4.1.181960.2^ISO|ALlab^simulated-lab-id^ISO|20240224134009||ORM^O01^ORM_O01|011|N|2.5.1||||||8859/1
PID|1||1300974^^^Baptist East^MR||ONE^TESTCASE||202402210152-0500|F^Female^HL70001||2106-3^White^HL70005|1234 GPCS WAY^^MONTGOMERY^Alabama^36117^USA^home^^Montgomery|||||||2227600015||||N^Not Hispanic or Latino^HL70189|||1|||||
NK1|1|ONE^MOMFIRST|MTH^Mother^HL70063||^^^^^804^5693861||||||||||||||||||||||||||||123456789^^^Medicaid&2.16.840.1.113883.4.446&ISO^MD||||000-00-0000^^^ssn&2.16.840.1.113883.4.1&ISO^SS
ORC|NW|2801690163^ORDERID||||||||||12345^^^^^^^^NPI&2.16.840.1.113883.4.6&ISO^L|||||||||
OBR|1|2801690163^ORDERID||54089-8^Newborn screening panel AHIC^LN|||202402221854-0500|||||||||12345^^^^^^^^NPI&2.16.840.1.113883.4.6&ISO^L||||||||
OBX|1|ST|57723-9^Unique bar code number of Current sample^LN||123456||||||F|||202402221854-0500
NTE|1||note 1|
NTE|2||note 2|
10 changes: 10 additions & 0 deletions rs-e2e/src/main/resources/assertion_definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,16 @@
"OBR.count() = 1",
"OBR-4.1 = '54089-8'"
]
},
{
"name": "NTE segment mapping",
"conditions": [
"MSH-10 = '011'"
],
"rules": [
"NTE-3 = 'note 1'",
pluckyswan marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

@GilmoreA6 GilmoreA6 Dec 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why we are using this rule but I don't love it since it only works because our HL7 parser only returns the first iteration of each segment/field and there is no indexing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using NTE-3 = input.NTE-3 which would work even if we add indexing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Changed it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran the automation test as well and it works.

"NTE.count() = 2"
]
}
]
}
Loading