Load Testing Doesn't Like Spaces

[halprin]

Description

The test-run-id argument when running the load tests could sometimes have spaces before the hour if the hour was less than 10. This extra space made the az CLI command think there was an extra argument that it didn't know what to do with, so it failed.

The test-run-id will now always have an underscore between the date and time and no spaces as padding if the hour is less than 10.

Issue

#1122.

Checklist

• Tested that this works with an underscore.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 1122 - Partially compliant Fully compliant requirements: Sign Flexion and CDC up for the Locust preview program. Implement load test in internal including authentication against the token endpoint and testing other endpoints. Set up a GitHub Action to run tests on a schedule. Update existing ADR and/or create new one. Update readme with how to run and modify load tests in deployed environments. Configure test criteria (failure thresholds) in Azure. Add some additional comments to app context and places where .getImplementation is used. Figure out why metadata endpoint is failing in load test. Look into why failing to link metadata results in 5XXs. Set up mock RS endpoints for load testing. Rename internal load testing to be better than jeff-load-test. Not compliant requirements: Figure out why load testing failed to start in an automated way. Move to future ticket: Look at why load tests cause 499s again.

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No major issues detected

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Correct the command substitution syntax to ensure it executes properly within the YAML workflow Ensure that the command substitution for date in the --test-run-id parameter is correctly formatted and executed within the YAML file. The current syntax might not be interpreted as expected when embedded in a YAML string. Consider using a preceding step to store the date in an environment variable or directly using GitHub Actions expressions if applicable. .github/workflows/azure-load-tests.yml [45] ---test-run-id "run_"`date +"%Y%m%d_%H%M%S"` \ +--test-run-id "run_${{ steps.date.outputs.value }}" \ Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies a potential issue with the command substitution syntax in a YAML context, which could lead to execution errors. Modifying it to use GitHub Actions expressions or environment variables would ensure more reliable execution.	7

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud