Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETOR Processing Tag #844

Merged
merged 46 commits into from
Feb 12, 2024
Merged

ETOR Processing Tag #844

merged 46 commits into from
Feb 12, 2024

Conversation

jorg3lopez
Copy link
Contributor

@jorg3lopez jorg3lopez commented Feb 5, 2024 •
edited
Loading

ETOR Processing Tag

This PR adds a tag to the meta section of the messageHeader resource so that RS knows not to send back the messages that we (TI) have processed. This is an essential part for fixing the sending loop.

Issue

Checklist

  • I have added tests to cover my changes
  • I have added logging where useful (with appropriate log level)
  • I have added JavaDocs where required
  • I have updated the documentation accordingly

@jorg3lopez
Copy link
Contributor Author

The mock_credentials PR was merged into this branch as I needed those changes for the API to work.

jcrichlake
jcrichlake reviewed Feb 5, 2024
View reviewed changes
etor/src/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiOrderConverter.java Outdated
HapiHelper.resourcesInBundle(messageBundle, MessageHeader.class).findFirst();
if (messageHeaderOptional.isPresent()) {
var messageHeader = messageHeaderOptional.get();
var meta = messageHeader.hasMeta() ? messageHeader.getMeta() : new Meta();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a Meta constructor that takes a Coding object so we don't have to call setMeta after?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. The Meta class is from the fhir library. If we want to overload its constructor, we will have to submit the request in their repo

@jcrichlake
Copy link
Contributor

Really nice stuff! It looks like there is a checkbox in the run configuration for the remote JVM debug that would allow you to store that configuration as a project file. What are your thoughts on checking that in to the repo for everyone to just have access to it?

saquino0827 and others added 15 commits February 5, 2024 14:41
@saquino0827
Add run config file
3f605e9
@jorg3lopez
Merge branch 'bug-fix-credentials-folder' into stream2-add-processing…
56f6b25 
…-tag-to-message
@jorg3lopez
changes:
7a525e4 
added etor processing tag to comment for test case
put the MetaStep enum in alphabetical order
@saquino0827
Add result converter and use case for adding TI identifier to message…
c0c4bdf 
… header
@saquino0827
Add test coverage
c63b792
@saquino0827
Add more unit test coverage
d0672f4
@saquino0827
Merge branch 'main' into stream2-add-processing-tag-to-message
35e51e3
@saquino0827
Merge branch 'main' into stream2-add-processing-tag-to-message
667f8d4
@jorg3lopez
Merge branch 'main' into stream2-add-processing-tag-to-message
5bc58a5
@saquino0827
Missing test coverage for HapiResult
eff01cc
@saquino0827
Remove unused import
e1dcf79
@jorg3lopez
refactoring of unit tests and format
4170cc5
@saquino0827
Refacotr etor tagging into message converter helper
f14f6aa
@saquino0827
Add unit test for HapiMessageConverterHelper
ee8f373
@jorg3lopez
Merge branch 'main' into stream2-add-processing-tag-to-message
75028e4
@jorg3lopez jorg3lopez marked this pull request as ready for review February 10, 2024 00:02
@jorg3lopez jorg3lopez marked this pull request as draft February 10, 2024 00:13
@jorg3lopez
Copy link
Contributor Author

We still need e2e

@jorg3lopez jorg3lopez marked this pull request as ready for review February 10, 2024 19:03
basiliskus
basiliskus reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@basiliskus basiliskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just left a couple of comments

...t/groovy/gov/hhs/cdc/trustedintermediary/external/hapi/HapiMessageConverterHelperTest.groovy Show resolved Hide resolved
...t/groovy/gov/hhs/cdc/trustedintermediary/external/hapi/HapiMessageConverterHelperTest.groovy Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jorg3lopez jorg3lopez merged commit cdc1b14 into main Feb 12, 2024
16 checks passed
@jorg3lopez jorg3lopez deleted the stream2-add-processing-tag-to-message branch February 12, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saquino0827 saquino0827 saquino0827 left review comments

@basiliskus basiliskus basiliskus approved these changes

@jcrichlake jcrichlake Awaiting requested review from jcrichlake

@halprin halprin Awaiting requested review from halprin

@tjohnson7021 tjohnson7021 Awaiting requested review from tjohnson7021

@rajeev-flexion rajeev-flexion Awaiting requested review from rajeev-flexion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorg3lopez @jcrichlake @basiliskus @saquino0827