Results Metadata Update #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the OperationalOutcome Metadata
- Updates PartnerMetadata to use it's own converter - Adds the sent submission id as it's own field - Updates unit tests and fixes e2e tests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rc/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiPartnerMetadataConverter.java
Fixed
Show fixed
Hide fixed
e2e/src/test/groovy/gov/hhs/cdc/trustedintermediary/e2e/MetadataTest.groovy
Outdated
Show resolved
Hide resolved
.../src/test/groovy/gov/hhs/cdc/trustedintermediary/external/hapi/HapiOrderConverterTest.groovy
Outdated
Show resolved
Hide resolved
basiliskus
reviewed
Mar 25, 2024
e2e/src/test/groovy/gov/hhs/cdc/trustedintermediary/e2e/MetadataTest.groovy
Show resolved
Hide resolved
halprin
reviewed
Mar 25, 2024
...rc/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiPartnerMetadataConverter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiPartnerMetadataConverter.java
Outdated
Show resolved
Hide resolved
halprin
requested changes
Mar 25, 2024
e2e/src/test/groovy/gov/hhs/cdc/trustedintermediary/e2e/MetadataTest.groovy
Show resolved
Hide resolved
- update tests to include outbound submission testing and outbound submission id/inbound submission id - remove metadata methods from OrderConverter and its implementation
….com/CDCgov/trusted-intermediary into story/650/results-metadata-new-issue
|
...rc/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiPartnerMetadataConverter.java
Show resolved
Hide resolved
halprin
approved these changes
Mar 27, 2024
| @@ -214,7 +217,7 @@ DomainResponse handleMetadata(DomainRequest request) { | |||
| } | |||
|
|
|||
| FhirMetadata<?> responseObject = | |||
| orderConverter.extractPublicMetadataToOperationOutcome( | |||
| partnerMetadataConverter.extractPublicMetadataToOperationOutcome( | |||
There was a problem hiding this comment.
Thanks for pulling this out of the order converter!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a PR title
Updates around metadata which include:
PartnerMetadataConverterover the originalOrderConverter.sent submission idas a new column when retrieving Metadata from the Metadata endpoint.Issue
Add a link to the issue here. Consider using
closing keywords
if the this PR isn't for a story (stories will be closed through different means).
Checklist
Note: You may remove items that are not applicable