Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RS scripts to simplify set up #981

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Add RS scripts to simplify set up #981

merged 4 commits into from
Mar 28, 2024

Conversation

basiliskus
Copy link
Contributor

@basiliskus basiliskus commented Mar 27, 2024 •
edited
Loading

Add RS scripts to simplify set up

  • Created scripts/rs folder to place scripts to be run in RS
  • Added script to set up RS vault secrets for local testing
  • Update RS set up instructions in readme accordingly

@basiliskus basiliskus marked this pull request as ready for review March 27, 2024 16:18
halprin
halprin reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@halprin halprin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help a lot, but I've got just a couple of comments.

README.md Outdated Show resolved Hide resolved
scripts/rs/setup-vault.sh Outdated Show resolved Hide resolved
halprin
halprin approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@halprin halprin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@basiliskus basiliskus merged commit 4e940cb into main Mar 28, 2024
15 checks passed
@basiliskus basiliskus deleted the chores/rs-setup-scripts branch March 28, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halprin halprin halprin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basiliskus @halprin