Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for resolve() missing from the HapiFhir library #984

Merged
merged 17 commits into from
Mar 29, 2024

Conversation

luis-pabon-tf
Copy link
Contributor

@luis-pabon-tf luis-pabon-tf commented Mar 28, 2024

Add implementation for resolve() missing from the HapiFhir library

  • Added missing implementation to resolve FHIR reference
  • Added more integration tests for validation rules
  • Minor fix to for rule names

Issue

#341

Checklist

  • I have added tests to cover my changes
  • I have added logging where useful (with appropriate log level)
  • I have added JavaDocs where required

@basiliskus basiliskus changed the title Story/341/fhir engine updates Add implementation for resolve() missing from the HapiFhir library Mar 28, 2024
@luis-pabon-tf luis-pabon-tf marked this pull request as ready for review March 29, 2024 15:59
import org.hl7.fhir.r4.model.Reference
import spock.lang.Specification

class HapiFhirCustomEvaluationContextTest extends Specification {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests!

Copy link

@basiliskus basiliskus merged commit d1b2375 into main Mar 29, 2024
15 checks passed
@basiliskus basiliskus deleted the story/341/fhir_engine_updates branch March 29, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants