621: Save Metadata from FHIR Sender/Receiver/Number #985
Conversation
halprin
changed the title
There was a problem hiding this comment.
Looks good to me. I guess this PR is waiting for implementation of the Order methods in PR #982
…updated Order and Result datatypes
|
Not sure why but I can't convert this PR back to a draft. I refactored this a bit from this PR being merged into main. Looking into setting up the our Dao with Postgresql jsonb datatypes and will update and fix test. |
etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/messages/SendMessageHelper.java
Show resolved
Hide resolved
…ov/trusted-intermediary into story-621-save_new_metadata
…adataStorage.java
…m DatabasePartnerMetadataStorage
etor/src/main/java/gov/hhs/cdc/trustedintermediary/external/database/PostgresDao.java
Outdated
Show resolved
Hide resolved
etor/src/main/java/gov/hhs/cdc/trustedintermediary/external/database/PostgresDao.java
Show resolved
Hide resolved
...gov/hhs/cdc/trustedintermediary/etor/metadata/partner/PartnerMetadataOrchestratorTest.groovy
Outdated
Show resolved
Hide resolved
…abasePartnerMetadataStorage
…ov/trusted-intermediary into story-621-save_new_metadata
…e all formatting scenarios
jorg3lopez
force-pushed
the
story-621-save_new_metadata
branch
from
880cf82 to
0b1427d
Compare
| metadata.receivedSubmissionId(), | ||
| false, | ||
| Types.VARCHAR), | ||
| new DbColumn("sent_message_id", metadata.sentSubmissionId(), true, Types.VARCHAR), |
There was a problem hiding this comment.
Thoughts on having final variables for the names?
There was a problem hiding this comment.
It was already a comment earlier in this PR to remove the variable names and put them directly in the List.
…stgresDao to remove calls to our Formatter
…ov/trusted-intermediary into story-621-save_new_metadata
There was a problem hiding this comment.
@saquino0827, this looks awesome except for an accidental commit of a merge conflict file. There's also a recommendation to change an import.
...a/gov/hhs/cdc/trustedintermediary/external/database/DatabasePartnerMetadataStorage.java.orig
Outdated
Show resolved
Hide resolved
etor/src/test/groovy/gov/hhs/cdc/trustedintermediary/external/database/PostgresDaoTest.groovy
Outdated
Show resolved
Hide resolved
|
Save Metadata from FHIR
This work bridges the work done in #982 and #983 by grabbing the data out of the FHIR resources and storing it into the database.
The vast majority of changes are adding the additional sender/receiver/number fields to
PartnerMetadataand any other methods that pipe these fields to where it needs to go.Because #982 isn't done yet, this PR is using dummy strings in
SendOrderUseCaseandSendResultUseCase. I feel like that PR should be merged in first before this one, so this PR will change slightly once that #982 is merged.Issue
#621.
Checklist
Note: You may remove items that are not applicable